Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc++] Re-enable backdeployment testing on arm64 macOS #99488

Closed

Conversation

ldionne
Copy link
Member

@ldionne ldionne commented Jul 18, 2024

No description provided.

@ldionne ldionne requested a review from a team as a code owner July 18, 2024 13:11
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Jul 18, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Jul 18, 2024

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/99488.diff

1 Files Affected:

  • (modified) libcxx/utils/ci/buildkite-pipeline.yml (+8-17)
diff --git a/libcxx/utils/ci/buildkite-pipeline.yml b/libcxx/utils/ci/buildkite-pipeline.yml
index 71d211bfc287d..39f3f62fff921 100644
--- a/libcxx/utils/ci/buildkite-pipeline.yml
+++ b/libcxx/utils/ci/buildkite-pipeline.yml
@@ -121,6 +121,14 @@ steps:
       arch: x86_64 # TODO: Remove this once we are able to run back-deployment on arm64 again, since this isn't x86_64 specific
     <<: *common
 
+  - label: "Apple back-deployment macosx11.0 arm64"
+    command: "libcxx/utils/ci/run-buildbot apple-system-backdeployment-11.0"
+    agents:
+      queue: libcxx-builders
+      os: macos
+      arch: arm64
+    <<: *common
+
 - group: ARM
   steps:
   - label: AArch64
@@ -230,20 +238,3 @@ steps:
       queue: libcxx-builders
       os: android
     <<: *common
-
-
-    # TODO: Re-enable this once we've figured out how to run back-deployment testing on arm64 on recent OSes
-    # - label: "Apple back-deployment macosx11.0 arm64"
-    #   command: "libcxx/utils/ci/run-buildbot apple-system-backdeployment-11.0"
-    #   artifact_paths:
-    #     - "**/test-results.xml"
-    #     - "**/*.abilist"
-    #   agents:
-    #     queue: "libcxx-builders"
-    #     os: "macos"
-    #     arch: "arm64"
-    #   retry:
-    #     automatic:
-    #       - exit_status: -1  # Agent was lost
-    #         limit: 2
-    #   timeout_in_minutes: 120

@ldionne
Copy link
Member Author

ldionne commented Sep 26, 2024

Closing since this will be moot once #109984 lands.

@ldionne ldionne closed this Sep 26, 2024
@ldionne ldionne deleted the review/reenable-arm64-backdeployment branch September 26, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants