Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc] Temporarily disable statvfs header #99405

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

michaelrj-google
Copy link
Contributor

The statfvs header was not generating for a while. Patch #98983 added it
to the list of headers, but it's apparently broken right now so this
patch comments it out until it can be fixed.

The statfvs header was not generating for a while. Patch llvm#98983 added it
to the list of headers, but it's apparently broken right now so this
patch comments it out until it can be fixed.
@llvmbot llvmbot added the libc label Jul 17, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Jul 17, 2024

@llvm/pr-subscribers-libc

Author: Michael Jones (michaelrj-google)

Changes

The statfvs header was not generating for a while. Patch #98983 added it
to the list of headers, but it's apparently broken right now so this
patch comments it out until it can be fixed.


Full diff: https://github.com/llvm/llvm-project/pull/99405.diff

1 Files Affected:

  • (modified) libc/config/linux/x86_64/headers.txt (+2-1)
diff --git a/libc/config/linux/x86_64/headers.txt b/libc/config/linux/x86_64/headers.txt
index 0294f62bc2f7a..8a52d80e1fbfb 100644
--- a/libc/config/linux/x86_64/headers.txt
+++ b/libc/config/linux/x86_64/headers.txt
@@ -45,7 +45,8 @@ set(TARGET_PUBLIC_HEADERS
     libc.include.sys_select
     libc.include.sys_socket
     libc.include.sys_stat
-    libc.include.sys_statvfs
+    # statvfs is broken, will uncomment once it's fixed.
+    # libc.include.sys_statvfs
     libc.include.sys_syscall
     libc.include.sys_time
     libc.include.sys_types

Copy link
Contributor

@aaryanshukla aaryanshukla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelrj-google michaelrj-google merged commit 90cbb1e into llvm:main Jul 17, 2024
6 of 7 checks passed
@michaelrj-google michaelrj-google deleted the libcStatfvsComment branch July 17, 2024 23:42
Harini0924 pushed a commit to Harini0924/llvm-project that referenced this pull request Jul 22, 2024
The statfvs header was not generating for a while. Patch llvm#98983 added it
to the list of headers, but it's apparently broken right now so this
patch comments it out until it can be fixed.
sgundapa pushed a commit to sgundapa/upstream_effort that referenced this pull request Jul 23, 2024
The statfvs header was not generating for a while. Patch llvm#98983 added it
to the list of headers, but it's apparently broken right now so this
patch comments it out until it can be fixed.
yuxuanchen1997 pushed a commit that referenced this pull request Jul 25, 2024
Summary:
The statfvs header was not generating for a while. Patch #98983 added it
to the list of headers, but it's apparently broken right now so this
patch comments it out until it can be fixed.

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60250898
@nickdesaulniers
Copy link
Member

Make sure to file bugs to track these easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants