-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libc] Temporarily disable statvfs header #99405
[libc] Temporarily disable statvfs header #99405
Conversation
The statfvs header was not generating for a while. Patch llvm#98983 added it to the list of headers, but it's apparently broken right now so this patch comments it out until it can be fixed.
@llvm/pr-subscribers-libc Author: Michael Jones (michaelrj-google) ChangesThe statfvs header was not generating for a while. Patch #98983 added it Full diff: https://github.com/llvm/llvm-project/pull/99405.diff 1 Files Affected:
diff --git a/libc/config/linux/x86_64/headers.txt b/libc/config/linux/x86_64/headers.txt
index 0294f62bc2f7a..8a52d80e1fbfb 100644
--- a/libc/config/linux/x86_64/headers.txt
+++ b/libc/config/linux/x86_64/headers.txt
@@ -45,7 +45,8 @@ set(TARGET_PUBLIC_HEADERS
libc.include.sys_select
libc.include.sys_socket
libc.include.sys_stat
- libc.include.sys_statvfs
+ # statvfs is broken, will uncomment once it's fixed.
+ # libc.include.sys_statvfs
libc.include.sys_syscall
libc.include.sys_time
libc.include.sys_types
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The statfvs header was not generating for a while. Patch llvm#98983 added it to the list of headers, but it's apparently broken right now so this patch comments it out until it can be fixed.
The statfvs header was not generating for a while. Patch llvm#98983 added it to the list of headers, but it's apparently broken right now so this patch comments it out until it can be fixed.
Summary: The statfvs header was not generating for a while. Patch #98983 added it to the list of headers, but it's apparently broken right now so this patch comments it out until it can be fixed. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60250898
Make sure to file bugs to track these easier. |
The statfvs header was not generating for a while. Patch #98983 added it
to the list of headers, but it's apparently broken right now so this
patch comments it out until it can be fixed.