Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libc++][ranges] P1223R5: find_last #99312

Merged
merged 10 commits into from
Jul 19, 2024
Merged

[libc++][ranges] P1223R5: find_last #99312

merged 10 commits into from
Jul 19, 2024

Commits on Jul 17, 2024

  1. P1223R5: find_last 

    Implements [P1223R5][] completely.

Includes an implementation of `find_last`, `find_last_if`, and
`find_last_if_not`.

[P1223R5]: https://wg21.link/p1223r5
    @strega-nil
    strega-nil committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    c162555 View commit details
    Browse the repository at this point in the history

  2. code review comments 

    - add `static` to `operator()`
- update release notes
    @strega-nil
    strega-nil committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    26fb328 View commit details
    Browse the repository at this point in the history

  3. attempt to fix it?

    @strega-nil
    strega-nil committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    c07e7f8 View commit details
    Browse the repository at this point in the history

  4. fixy fixy

    @strega-nil
    strega-nil committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    f7b799d View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. (wip) merge ranges_find_last*.h into ranges_find_last.h 

    Additionally, make __find_last_impl into one function for all three

Finally, change the tests for find_last to see if people are good with that version
(hopefully, yes, in which case I'll do the rest)
    @strega-nil
    strega-nil committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ec67129 View commit details
    Browse the repository at this point in the history

  2. fix tests

    @strega-nil
    strega-nil committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    8b9e401 View commit details
    Browse the repository at this point in the history

  3. finish off the tests

    @strega-nil
    strega-nil committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    86a52f5 View commit details
    Browse the repository at this point in the history

  4. format it

    @strega-nil
    strega-nil committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    89c15f3 View commit details
    Browse the repository at this point in the history

  5. ldionne's recommendations

    @strega-nil
    strega-nil committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    d186443 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. format dangit

    @strega-nil
    strega-nil committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    a09b6d5 View commit details
    Browse the repository at this point in the history