Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libcxx] Add LIBCXX_HAS_TERMINAL_AVAILABLE CMake option to disable print terminal checks #99259

Merged
merged 3 commits into from
Aug 21, 2024
Merged

[libcxx] Add LIBCXX_HAS_TERMINAL_AVAILABLE CMake option to disable print terminal checks #99259

merged 3 commits into from
Aug 21, 2024

Commits on Aug 14, 2024

  1. [libcxx] Make terminal check always false for print on GPU 

    Summary:
This check must be handled in order to compile. The GPU cannot easily
determine if a given `FILE *` is a terminal because the `stdio`
interface is actually a wrapper over the system's `FILE *`, so we can't
really detect it easily. An RPC call could be made to `isatty` if we
really need to support this in the future.
    @jhuber6
    jhuber6 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    670192d View commit details
    Browse the repository at this point in the history

  2. Address comments

    @jhuber6
    jhuber6 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    edb96ee View commit details
    Browse the repository at this point in the history

  3. address comments

    @jhuber6
    jhuber6 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    95ff1b9 View commit details
    Browse the repository at this point in the history