[SandboxIR][NFC] Move sandboxir::Use into a separate file #99074
Conversation
llvm/include/llvm/SandboxIR/Use.h
Outdated
| #include "llvm/Support/raw_ostream.h" | ||
|
|
||
| namespace llvm { | ||
| namespace sandboxir { |
There was a problem hiding this comment.
Maybe not. llvm::Use could be forward declared. IIRC raw_ostream can also be forward declared.
There was a problem hiding this comment.
Why would we forward declare llvm::Use?
There was a problem hiding this comment.
Including llvm IR header files is not going to cause any dependency issues, so I think it should be fine to keep it this way.
| void dump(raw_ostream &OS) const; | ||
| void dump() const; | ||
| #endif // NDEBUG | ||
| }; |
There was a problem hiding this comment.
A new line would be nice, but ...
llvm/include/llvm/SandboxIR/Use.h
Outdated
| @@ -0,0 +1,51 @@ | |||
| #ifndef LLVM_TRANSFORMS_SANDBOXIR_USE_H | |||
| #define LLVM_TRANSFORMS_SANDBOXIR_USE_H | |||
There was a problem hiding this comment.
This is not in the transforms directory. Maybe there was a version in transforms. The include guard looks odd.
There was a problem hiding this comment.
It's also missing the LLVM header!
There was a problem hiding this comment.
The TRANSFORMS was copy-pasted from SandboxIR.h.
There was a problem hiding this comment.
True, let me fix that too.
This helps avoid circular dependencies in a follow-up patch.
This helps avoid circular dependencies in a follow-up patch.
Summary: This helps avoid circular dependencies in a follow-up patch. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60251433
This helps avoid circular dependencies in a follow-up patch.