Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libc++][test] XFAIL sized deallocation tests for AIX, z/OS, and MinGW #98960

Merged
merged 2 commits into from
Jul 18, 2024
Merged

[libc++][test] XFAIL sized deallocation tests for AIX, z/OS, and MinGW #98960

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c26ca8c
XFAIL sized deallocation tests for AIX, z/OS, and MinGW.
xingxue-ibm Jul 15, 2024
352b433
Use target={{.+}}-windows-gnu for MinGW.
xingxue-ibm Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...anguage.support/support.dynamic/new.delete/new.delete.array/sized_delete_array14.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
// XFAIL: apple-clang
// XFAIL: using-built-library-before-llvm-11

// AIX, z/OS, and MinGW default to -fno-sized-deallocation.
// XFAIL: target={{.+}}-aix{{.*}}, target={{.+}}-zos{{.*}}, target={{.+}}-mingw32{{.*}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patterns for mingw here should be {{.*}}-windows-gnu - the triples get normalized into that form. Please grep for that and see which exact spelling we use elsewhere (can’t easily check myself ATM).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Or {{.+}} for the arch obviously is fine too.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Targets used for MinGW are as follows. I will change to use {{.+}}-windows-gnu as suggested. Thanks, @mstorsjo!

target=x86_64-w64-windows-gnu
target=i686-w64-windows-gnu


#include <new>
#include <cstddef>
#include <cstdlib>
Expand Down
3 changes: 3 additions & 0 deletions ...std/language.support/support.dynamic/new.delete/new.delete.single/sized_delete14.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
// XFAIL: apple-clang
// XFAIL: using-built-library-before-llvm-11

// AIX, z/OS, and MinGW default to -fno-sized-deallocation.
// XFAIL: target={{.+}}-aix{{.*}}, target={{.+}}-zos{{.*}}, target={{.+}}-mingw32{{.*}}

#include <new>
#include <cstddef>
#include <cstdlib>
Expand Down
Loading