Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libc++] Fix acceptance of convertible-to-{float,double,long double} in std::isfinite() #98841

Merged
merged 9 commits into from
Jul 18, 2024
Merged

[libc++] Fix acceptance of convertible-to-{float,double,long double} in std::isfinite() #98841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3827e6f
Reproduce error by a test
robincaloudis Jul 14, 2024
9dcd0cf
Provide float overload
robincaloudis Jul 14, 2024
121bad4
Reproduce error by a test for double overload
robincaloudis Jul 14, 2024
23f4a4c
Provide double overload for isfinite()
robincaloudis Jul 14, 2024
90d2737
Reproduce another error by a test
robincaloudis Jul 14, 2024
9df4a55
Provide long double overload
robincaloudis Jul 14, 2024
86f5933
Fix formatting
robincaloudis Jul 14, 2024
c858bb6
Remove preprocessor directive
robincaloudis Jul 15, 2024
8d56623
Extract template and leave comment
robincaloudis Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions libcxx/include/__math/traits.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,18 @@ _LIBCPP_NODISCARD _LIBCPP_CONSTEXPR_SINCE_CXX23 _LIBCPP_HIDE_FROM_ABI bool isfin
return true;
}

_LIBCPP_NODISCARD inline _LIBCPP_CONSTEXPR_SINCE_CXX23 _LIBCPP_HIDE_FROM_ABI bool isfinite(float __x) _NOEXCEPT {
return __builtin_isfinite(__x);
}

_LIBCPP_NODISCARD inline _LIBCPP_CONSTEXPR_SINCE_CXX23 _LIBCPP_HIDE_FROM_ABI bool isfinite(double __x) _NOEXCEPT {
return __builtin_isfinite(__x);
}

_LIBCPP_NODISCARD inline _LIBCPP_CONSTEXPR_SINCE_CXX23 _LIBCPP_HIDE_FROM_ABI bool isfinite(long double __x) _NOEXCEPT {
return __builtin_isfinite(__x);
}

// isinf

template <class _A1, __enable_if_t<is_arithmetic<_A1>::value && numeric_limits<_A1>::has_infinity, int> = 0>
Expand Down
12 changes: 12 additions & 0 deletions libcxx/test/std/numerics/c.math/isfinite.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,21 @@ struct TestInt {
}
};

template <typename T>
struct ConvertibleTo {
operator T() const { return T(); }
};

int main(int, char**) {
types::for_each(types::floating_point_types(), TestFloat());
types::for_each(types::integral_types(), TestInt());

// Make sure we can call `std::isfinite` with convertible types
{
assert(std::isfinite(ConvertibleTo<float>()));
assert(std::isfinite(ConvertibleTo<double>()));
assert(std::isfinite(ConvertibleTo<long double>()));
}

return 0;
}
Loading