Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LoopRotate] Don't rotate loops when the minsize attribute is present #98815

Merged
merged 1 commit into from
Jul 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions llvm/lib/Transforms/Scalar/LoopRotation.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,11 @@ PreservedAnalyses LoopRotatePass::run(Loop &L, LoopAnalysisManager &AM,
// Vectorization requires loop-rotation. Use default threshold for loops the
// user explicitly marked for vectorization, even when header duplication is
// disabled.
int Threshold = EnableHeaderDuplication ||
hasVectorizeTransformation(&L) == TM_ForcedByUser
? DefaultRotationThreshold
: 0;
int Threshold =
(EnableHeaderDuplication && !L.getHeader()->getParent()->hasMinSize()) ||
hasVectorizeTransformation(&L) == TM_ForcedByUser
? DefaultRotationThreshold
: 0;
const DataLayout &DL = L.getHeader()->getDataLayout();
const SimplifyQuery SQ = getBestSimplifyQuery(AR, DL);

Expand Down
32 changes: 32 additions & 0 deletions llvm/test/Transforms/LoopRotate/minsize-disable.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
; REQUIRES: asserts
; RUN: opt < %s -S -passes=loop-rotate -debug -debug-only=loop-rotate 2>&1 | FileCheck %s

; Loop should not be rotated for functions with the minsize attribute.
; This is mostly useful for LTO which doesn't (yet) understand -Oz.
; CHECK: LoopRotation: NOT rotating - contains 2 instructions, which is more

@e = global i32 10

declare void @use(i32)

; Function attrs: minsize optsize
define void @test() #0 {
entry:
%end = load i32, ptr @e
br label %loop

loop:
%n.phi = phi i32 [ %n, %loop.fin ], [ 0, %entry ]
%cond = icmp eq i32 %n.phi, %end
br i1 %cond, label %exit, label %loop.fin

loop.fin:
%n = add i32 %n.phi, 1
call void @use(i32 %n)
br label %loop

exit:
ret void
}

attributes #0 = { minsize optsize }
Loading