Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compiler-rt][nsan] Disable coredump creation #98807

Merged
merged 2 commits into from
Jul 15, 2024
Merged

[compiler-rt][nsan] Disable coredump creation #98807

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0549414
[compiler-rt][nsan] Add two steps in init process
chestnykh Jul 14, 2024
78d5eb4
[compiler-rt][nsan] Don't install signal handler
chestnykh Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion compiler-rt/lib/nsan/nsan.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,10 @@ int32_t checkFT(const FT value, ShadowFT Shadow, CheckTypeT CheckType,
}

if (flags().halt_on_error) {
Printf("Exiting\n");
if (common_flags()->abort_on_error)
Printf("ABORTING\n");
else
Printf("Exiting\n");
Die();
}
return flags().resume_after_warning ? kResumeFromValue : kContinueWithShadow;
Expand Down Expand Up @@ -776,6 +779,16 @@ extern "C" SANITIZER_INTERFACE_ATTRIBUTE void __nsan_dump_shadow_args() {
printf("args tag: %lx\n", __nsan_shadow_args_tag);
}

static void OnStackUnwind(const SignalContext &sig, const void *,
BufferedStackTrace *stack) {
stack->Unwind(StackTrace::GetNextInstructionPc(sig.pc), sig.bp, sig.context,
common_flags()->fast_unwind_on_fatal);
}

static void NsanOnDeadlySignal(int signo, void *siginfo, void *context) {
HandleDeadlySignal(siginfo, context, GetTid(), &OnStackUnwind, nullptr);
}

bool __nsan::nsan_initialized;
bool __nsan::nsan_init_is_running;

Expand All @@ -789,6 +802,9 @@ extern "C" SANITIZER_INTERFACE_ATTRIBUTE void __nsan_init() {
InitializeSuppressions();
InitializePlatformEarly();

DisableCoreDumperIfNecessary();
InstallDeadlySignalHandlers(NsanOnDeadlySignal);

if (!MmapFixedNoReserve(TypesAddr(), UnusedAddr() - TypesAddr()))
Die();

Expand Down
Loading