Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADT] Add a missing call to a unique_function destructor after move #98747

Merged
merged 9 commits into from
Aug 19, 2024
Merged

[ADT] Add a missing call to a unique_function destructor after move #98747

merged 9 commits into from
Aug 19, 2024

Commits on Aug 19, 2024

  1. [ADT] Add a missing call to a unique_function destructor after move 

    Right now immediately after moving the captured state, we `disarm` the moved-from object's destructor by resetting the `RHS.CallbackAndInlineFlag`. This means that we never properly destroy the RHS object's captured state.
    @kerambyte
    kerambyte committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    e545ece View commit details
    Browse the repository at this point in the history

  2. add a unit test

    @kerambyte
    kerambyte committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    ac0b93b View commit details
    Browse the repository at this point in the history

  3. refactor the test

    @kerambyte
    kerambyte committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    7d5d4a6 View commit details
    Browse the repository at this point in the history

  4. cleanup

    @kerambyte
    kerambyte committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    e9f39e8 View commit details
    Browse the repository at this point in the history

  5. refactor the test and fix alignment issue

    @kerambyte
    kerambyte committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    74ea9a8 View commit details
    Browse the repository at this point in the history

  6. remove alignment fix

    @kerambyte
    kerambyte committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    832e182 View commit details
    Browse the repository at this point in the history

  7. update names

    @kerambyte
    kerambyte committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a6682af View commit details
    Browse the repository at this point in the history

  8. fix formatting

    @kerambyte
    kerambyte committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    f9e0630 View commit details
    Browse the repository at this point in the history

  9. fix merge issue

    @kerambyte
    kerambyte committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    adce337 View commit details
    Browse the repository at this point in the history