[libc] Add missing dependency on src.__support.macros.config #98552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We automatically inject this dependency into all object libraries that use the libc CMake functions, but libc_diff_test_utils uses add_library so we need to add this dependency manually.
|
This should address the build failure seen here: https://lab.llvm.org/buildbot/#/builders/153/builds/2695 |
|
@llvm/pr-subscribers-libc Author: Petr Hosek (petrhosek) ChangesWe automatically inject this dependency into all object libraries that use the libc CMake functions, but libc_diff_test_utils uses add_library so we need to add this dependency manually. Full diff: https://github.com/llvm/llvm-project/pull/98552.diff 1 Files Affected:
diff --git a/libc/test/src/math/performance_testing/CMakeLists.txt b/libc/test/src/math/performance_testing/CMakeLists.txt
index bf88fbb85c5d7..787e733fd3e14 100644
--- a/libc/test/src/math/performance_testing/CMakeLists.txt
+++ b/libc/test/src/math/performance_testing/CMakeLists.txt
@@ -3,6 +3,7 @@ add_library(
Timer.cpp
Timer.h
)
+add_dependencies(libc_diff_test_utils libc.src.__support.macros.config)
# A convenience target to build all performance tests.
add_custom_target(libc-math-performance-tests)
|
jhuber6
approved these changes
Jul 11, 2024
michaelrj-google
approved these changes
Jul 11, 2024
aaryanshukla
pushed a commit
to aaryanshukla/llvm-project
that referenced
this pull request
Jul 14, 2024
…98552) We automatically inject this dependency into all object libraries that use the libc CMake functions, but `libc_diff_test_utils` uses `add_library` so we need to add this dependency manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We automatically inject this dependency into all object libraries that use the libc CMake functions, but libc_diff_test_utils uses add_library so we need to add this dependency manually.