Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MLIR][OpenMP] NFC: Address tablegen warnings #98485

Merged
merged 1 commit into from
Jul 15, 2024
Merged

[MLIR][OpenMP] NFC: Address tablegen warnings #98485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,12 @@ def ParallelOp : OpenMP_Op<"parallel", traits = [
RecursiveMemoryEffects
], clauses = [
// TODO: Sort clauses alphabetically.
OpenMP_IfClause, OpenMP_NumThreadsClause, OpenMP_AllocateClause,
OpenMP_ReductionClause, OpenMP_ProcBindClause, OpenMP_PrivateClause
OpenMP_IfClauseSkip<assemblyFormat = true>,
OpenMP_NumThreadsClauseSkip<assemblyFormat = true>,
OpenMP_AllocateClauseSkip<assemblyFormat = true>,
OpenMP_ReductionClauseSkip<assemblyFormat = true>,
OpenMP_ProcBindClauseSkip<assemblyFormat = true>,
OpenMP_PrivateClauseSkip<assemblyFormat = true>
], singleRegion = true> {
let summary = "parallel construct";
let description = [{
Expand All @@ -154,7 +158,8 @@ def ParallelOp : OpenMP_Op<"parallel", traits = [

// TODO: Use default assembly format inherited from OpenMP_Op once printing
// and parsing of the parallel region is not intermingled with printing and
// parsing of reduction and private clauses.
// parsing of reduction and private clauses. `assemblyFormat` should also be
// no longer skipped for clauses added to this operation at that time.
let assemblyFormat = [{
oilist(
`if` `(` $if_expr `)`
Expand Down Expand Up @@ -363,8 +368,12 @@ def WsloopOp : OpenMP_Op<"wsloop", traits = [
], clauses = [
// TODO: Complete clause list (allocate, private).
// TODO: Sort clauses alphabetically.
OpenMP_LinearClause, OpenMP_ReductionClause, OpenMP_ScheduleClause,
OpenMP_NowaitClause, OpenMP_OrderedClause, OpenMP_OrderClause
OpenMP_LinearClauseSkip<assemblyFormat = true>,
OpenMP_ReductionClauseSkip<assemblyFormat = true>,
OpenMP_ScheduleClauseSkip<assemblyFormat = true>,
OpenMP_NowaitClauseSkip<assemblyFormat = true>,
OpenMP_OrderedClauseSkip<assemblyFormat = true>,
OpenMP_OrderClauseSkip<assemblyFormat = true>
], singleRegion = true> {
let summary = "worksharing-loop construct";
let description = [{
Expand Down Expand Up @@ -398,7 +407,8 @@ def WsloopOp : OpenMP_Op<"wsloop", traits = [

// TODO: Use default assembly format inherited from OpenMP_Op once printing
// and parsing of the workshare loop region is not intermingled with printing
// and parsing of reduction clauses.
// and parsing of reduction clauses. `assemblyFormat` should also be no longer
// skipped for clauses added to this operation at that time.
let assemblyFormat = [{
oilist(`linear` `(`
custom<LinearClause>($linear_vars, type($linear_vars),
Expand Down
Loading