Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc++] Handle _LIBCPP_HAS_NO_{THREADS,LOCALIZATION} consistently with other carve-outs #98319

Merged
merged 2 commits into from
Jul 15, 2024

Commits on Jul 10, 2024

  1. [libc++] Handle _LIBCPP_HAS_NO_{THREADS,LOCALIZATION} consistently wi…

    …th other carve-outs
    
    Previously, we would issue an #error when using a header that requires
    threading support or localization support in a configuration where that
    is disabled. This is unlike what we do for all the other carve outs
    like no-filesystem, no-wide-characters or no-random-device. Instead of
    issuing an #error, we normally just remove the problematic parts of the
    header.
    
    This patch makes the handling of no-localization and no-threads consistent
    with the other carve-outs. I dislike the fact that users won't get an
    explicit error message when trying to use e.g. ios in a build that doesn't
    support localization, but I think it is better to handle things consistently.
    Note that besides the consistency argument, the #error approach doesn't
    really work anyways since it would break down if we moved towards assuming
    the C locale only in the no-localization mode.
    ldionne committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    e37a5c2 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Add release note

    ldionne committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    7a580c5 View commit details
    Browse the repository at this point in the history