[libc] Use stdio.h for off_t instead of unistd.h
#98093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The `stdio.h` header should define `off_t` as defined for the platform. This will use the system's in overlay mode, or what the llvm-libc-types deems correct. If this `off_t` is incorrect it should be changed in `llvm-libc-types`. This fixes the GPU build.
jhuber6
requested review from
Artem-B,
lntue,
michaelrj-google and
mikhailramalho
|
@llvm/pr-subscribers-libc Author: Joseph Huber (jhuber6) ChangesSummary: Full diff: https://github.com/llvm/llvm-project/pull/98093.diff 1 Files Affected:
diff --git a/libc/src/__support/File/file.h b/libc/src/__support/File/file.h
index ec543ac1ac5f3..828e71424c593 100644
--- a/libc/src/__support/File/file.h
+++ b/libc/src/__support/File/file.h
@@ -16,7 +16,7 @@
#include <stddef.h>
#include <stdint.h>
-#include <unistd.h> // For off_t.
+#include <stdio.h>
namespace LIBC_NAMESPACE {
|
michaelrj-google
approved these changes
Jul 8, 2024
| @@ -16,7 +16,7 @@ | |||
|
|
|||
| #include <stddef.h> | |||
| #include <stdint.h> | |||
| #include <unistd.h> // For off_t. | |||
| #include <stdio.h> | |||
There was a problem hiding this comment.
could you add a TODO to move these to proper proxy header?
mikhailramalho
approved these changes
Jul 9, 2024
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/43/builds/1637 Here is the relevant piece of the build log for the reference: |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/147/builds/1584 Here is the relevant piece of the build log for the reference: |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/2317 Here is the relevant piece of the build log for the reference: |
aaryanshukla
pushed a commit
to aaryanshukla/llvm-project
that referenced
this pull request
Jul 14, 2024
Summary: The `stdio.h` header should define `off_t` as defined for the platform. This will use the system's in overlay mode, or what the llvm-libc-types deems correct. If this `off_t` is incorrect it should be changed in `llvm-libc-types`. This fixes the GPU build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
stdio.hheader should defineoff_tas defined for the platform.This will use the system's in overlay mode, or what the llvm-libc-types
deems correct. If this
off_tis incorrect it should be changed inllvm-libc-types. This fixes the GPU build.