Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug that undefined internal is a warning only for -pedantic-errors #98016

Merged
merged 12 commits into from
Jul 11, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions clang/docs/ReleaseNotes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -554,6 +554,9 @@ Attribute Changes in Clang

Improvements to Clang's diagnostics
-----------------------------------
- Clang now emits an error instead of a warning for `undefined_internal`
ccrownhill marked this conversation as resolved.
Show resolved Hide resolved
when compiling with `-pedantic-errors` to conform to the C standard

- Clang now applies syntax highlighting to the code snippets it
prints.

Expand Down
2 changes: 1 addition & 1 deletion clang/include/clang/Basic/DiagnosticSemaKinds.td
Original file line number Diff line number Diff line change
Expand Up @@ -6013,7 +6013,7 @@ def note_deleted_assign_field : Note<
"because field %2 is of %select{reference|const-qualified}4 type %3">;

// These should be errors.
def warn_undefined_internal : Warning<
def warn_undefined_internal : ExtWarn<
"%select{function|variable}0 %q1 has internal linkage but is not defined">,
InGroup<DiagGroup<"undefined-internal">>;
def err_undefined_internal_type : Error<
Expand Down
10 changes: 10 additions & 0 deletions clang/test/Sema/undefined-internal-alignof.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// RUN: %clang_cc1 -fsyntax-only -verify %s -pedantic-errors
ccrownhill marked this conversation as resolved.
Show resolved Hide resolved

static void f(void); // expected-no-error

int main(void)
{
int i = _Alignof(f);
// expected-error@-1 {{'_Alignof' applied to an expression is a GNU extension}}
// expected-error@-2 {{invalid application of 'alignof' to a function type}}
}
11 changes: 11 additions & 0 deletions clang/test/Sema/undefined-internal-basic.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
// RUN: %clang_cc1 -fsyntax-only -verify %s -pedantic-errors
ccrownhill marked this conversation as resolved.
Show resolved Hide resolved

static void f(void); // expected-error {{function 'f' has internal linkage but is not defined}}

int main(void)
{
f;
// expected-note@-1 {{used here}}
// expected-warning@-2 {{expression result unused}}
}

12 changes: 12 additions & 0 deletions clang/test/Sema/undefined-internal-generic-selection.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// RUN: %clang_cc1 -fsyntax-only -verify %s -pedantic-errors

static void *f(void); // expected-error {{function 'f' has internal linkage but is not defined}}

int main(void)
{
int j = _Generic(&f, void *(*)(void): 10, default: 20);
// expected-no-diagnostic@-1

void *k = _Generic(&f, void *(*)(void): f(), default: 20);
ccrownhill marked this conversation as resolved.
Show resolved Hide resolved
// expected-note@-1 {{used here}}
}
10 changes: 10 additions & 0 deletions clang/test/Sema/undefined-internal-sizeof.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// RUN: %clang_cc1 -fsyntax-only -verify %s -pedantic-errors
ccrownhill marked this conversation as resolved.
Show resolved Hide resolved

// expected-no-diagnostics

static int f(void);

int main(void)
{
int x = sizeof f();
ccrownhill marked this conversation as resolved.
Show resolved Hide resolved
}
10 changes: 10 additions & 0 deletions clang/test/Sema/undefined-internal-typeof-c23.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// RUN: %clang_cc1 -fsyntax-only -verify %s -std=c23 -pedantic-errors

// expected-no-diagnostics

static int f(void);

int main(void)
{
typeof(f()) x;
ccrownhill marked this conversation as resolved.
Show resolved Hide resolved
}
Loading