Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc++abi] Use target_compile_options to pass LIBCXXABI_ADDITIONAL_COMPILE_FLAGS #96112

Merged

Commits on Jun 19, 2024

  1. [libc++abi] Use target_compile_options to pass LIBCXXABI_ADDITIONAL_C…

    …OMPILE_FLAGS
    
    We use target_compile_options to pass the libc++ variant of this flag, so
    we should be consistent for libc++abi. This is actually not only a matter
    of consistency: target_compile_options handles duplicate CMake options in
    a certain way (it removes duplicates but has an escape hatch using the
    "SHELL:" prefix), and it is important for both libc++ and libc++abi
    options to be handled in the same way.
    ldionne committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    59ea50c View commit details
    Browse the repository at this point in the history