Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc++] Add a release note about C++03 being frozen after LLVM 21 #95894

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

philnik777
Copy link
Contributor

No description provided.

@philnik777 philnik777 requested a review from a team as a code owner June 18, 2024 08:43
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Jun 18, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Jun 18, 2024

@llvm/pr-subscribers-libcxx

Author: Nikolas Klauser (philnik777)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/95894.diff

1 Files Affected:

  • (modified) libcxx/docs/ReleaseNotes/19.rst (+3-1)
diff --git a/libcxx/docs/ReleaseNotes/19.rst b/libcxx/docs/ReleaseNotes/19.rst
index 71de10abb6eaa..cffe40cec2618 100644
--- a/libcxx/docs/ReleaseNotes/19.rst
+++ b/libcxx/docs/ReleaseNotes/19.rst
@@ -77,6 +77,8 @@ Improvements and New Features
 Deprecations and Removals
 -------------------------
 
+- The status of the C++03 implementation will be frozen. From now on only bug fixes will be back-ported to C++03.
+
 - The C++20 synchronization library (``<barrier>``, ``<latch>``, ``atomic::wait``, etc.) has been deprecated
   in language modes prior to C++20. If you are using these features prior to C++20, please update to ``-std=c++20``.
   In LLVM 20, the C++20 synchronization library will be removed entirely in language modes prior to C++20.
@@ -133,8 +135,8 @@ LLVM 20
 
 LLVM 21
 ~~~~~~~
-TODO
 
+- Libc++ will no longer back-port non-critical bug fixes to C++03.
 
 ABI Affecting Changes
 ---------------------

Copy link
Member

@ldionne ldionne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I'd like a bit more verbosity though, I think this change is important enough that we need to do a good job at communicating it.

libcxx/docs/ReleaseNotes/19.rst Outdated Show resolved Hide resolved
libcxx/docs/ReleaseNotes/19.rst Outdated Show resolved Hide resolved
libcxx/docs/ReleaseNotes/19.rst Outdated Show resolved Hide resolved
@tschuett
Copy link
Member

Could you add a 21.rst with the related news?

@ldionne ldionne added this to the LLVM 19.X Release milestone Jul 9, 2024
@ldionne ldionne changed the title [libc++] Add a release note about C++03 being frozen in LLVM 19 [libc++] Add a release note about C++03 being frozen after LLVM 21 Jul 18, 2024
Copy link
Member

@ldionne ldionne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the reformulation!

In particular, I think it's important not to commit to a particular implementation of this proposal. The steps laid out in https://discourse.llvm.org/t/rfc-freezing-c-03-headers-in-libc/77319/55 are nice, but we don't know if it's actually going to work exactly that way.

Also, I think we must avoid promising that we're going to freeze the headers completely, since that may not be achievable.

libcxx/docs/ReleaseNotes/19.rst Outdated Show resolved Hide resolved
@philnik777 philnik777 merged commit 0ce11a1 into llvm:main Jul 18, 2024
6 of 12 checks passed
@philnik777 philnik777 deleted the cxx03_release_note branch July 18, 2024 16:04
Harini0924 pushed a commit to Harini0924/llvm-project that referenced this pull request Jul 22, 2024
sgundapa pushed a commit to sgundapa/upstream_effort that referenced this pull request Jul 23, 2024
yuxuanchen1997 pushed a commit that referenced this pull request Jul 25, 2024
…95894)

Summary: Co-authored-by: Louis Dionne <[email protected]>

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60251018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants