Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenMP] Use new OMPT state and sync kinds for barrier events #95602

Merged
merged 6 commits into from
Jul 16, 2024

Conversation

hansangbae
Copy link
Contributor

This change makes the runtime use new OMPT state and sync kinds introduced in OpenMP 5.1 in place of the deprecated implicit state and sync kinds. Events from implicit barriers use different enumerators for workshare, parallel, and teams.

This change makes the runtime use new OMPT state and sync kinds
introduced in OpenMP 5.1 in place of the deprecated implicit
state and sync kinds. Events from implicit barriers use different
enumerators for workshare, parallel, and teams.
Copy link

github-actions bot commented Jun 14, 2024

✅ With the latest revision this PR passed the C/C++ code formatter.

@hansangbae hansangbae added the openmp:libomp OpenMP host runtime label Jun 14, 2024
@hansangbae hansangbae marked this pull request as ready for review June 14, 2024 21:48
@Thyre
Copy link

Thyre commented Jul 8, 2024

I've tried the branch with Score-P and a simple printf tool and the results looked reasonable.
Would it make sense to differentiate the barrier types in the tests to ensure that the correct barrier types are returned, if possible? A similar thing was done with the loop types in #97429.

@llvmbot llvmbot added the openmp:libomptarget OpenMP offload runtime label Jul 8, 2024
@hansangbae
Copy link
Contributor Author

I've tried the branch with Score-P and a simple printf tool and the results looked reasonable. Would it make sense to differentiate the barrier types in the tests to ensure that the correct barrier types are returned, if possible? A similar thing was done with the loop types in #97429.

I updated the affected ompt tests.

Copy link
Collaborator

@jprotze jprotze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@hansangbae hansangbae merged commit 7a72856 into llvm:main Jul 16, 2024
6 checks passed
sayhaan pushed a commit to sayhaan/llvm-project that referenced this pull request Jul 16, 2024
…5602)

Summary:
This change makes the runtime use new OMPT state and sync kinds
introduced in OpenMP 5.1 in place of the deprecated implicit state and
sync kinds. Events from implicit barriers use different enumerators for
workshare, parallel, and teams.

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D59822458
@hansangbae hansangbae deleted the 20240614-ompt-barrier-event branch July 16, 2024 22:12
yuxuanchen1997 pushed a commit that referenced this pull request Jul 25, 2024
Summary:
This change makes the runtime use new OMPT state and sync kinds
introduced in OpenMP 5.1 in place of the deprecated implicit state and
sync kinds. Events from implicit barriers use different enumerators for
workshare, parallel, and teams.

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60251726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openmp:libomp OpenMP host runtime openmp:libomptarget OpenMP offload runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants