Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JITLink][LoongArch] Handle R_LARCH_GOT_PC_{HI20,LO12} fixups #94589

Closed
wants to merge 1 commit into from

Conversation

zhaoqi5
Copy link
Contributor

@zhaoqi5 zhaoqi5 commented Jun 6, 2024

In default,
RequestGOTAndTransformToPage20/RequestGOTAndTransformToPageOffset12 is transformed to Page20/PageOffset12. Only the latter are later handled when applying fixups, the former are simply ignored.

This patch proposes to handle RequestGOTAndTransformTo* anyway when applying fixups to support custom configurations. This enables GOT entries from the input binary can be reused, BOLT is one such example.

In default,
RequestGOTAndTransformToPage20/RequestGOTAndTransformToPageOffset12
is transformed to Page20/PageOffset12. Only the latter are later
handled when applying fixups, the former are simply ignored.

This patch proposes to handle RequestGOTAndTransformTo* anyway when
applying fixups to support custom configurations. This enables GOT
entries from the input binary can be reused, BOLT is one such example.
@SixWeining SixWeining requested a review from wangleiat June 7, 2024 06:48
@zhaoqi5
Copy link
Contributor Author

zhaoqi5 commented Jul 16, 2024

This patch is not needed.

@zhaoqi5 zhaoqi5 closed this Jul 16, 2024
@zhaoqi5 zhaoqi5 deleted the handle-gotpc-fixups branch July 16, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant