Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libc++][math] Fix undue overflowing of std::hypot(x,y,z) #93350

Merged
merged 22 commits into from
Jul 23, 2024
Merged

[libc++][math] Fix undue overflowing of std::hypot(x,y,z) #93350

merged 22 commits into from
Jul 23, 2024

Commits on Jul 16, 2024

  1. make use of C++17 is_same_v

    @PaulXiCao
    PaulXiCao committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    ced7b52 View commit details
    Browse the repository at this point in the history

  2. style change: align argument types

    @PaulXiCao
    PaulXiCao committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    f38b1dc View commit details
    Browse the repository at this point in the history

  3. implementation+testing

    @PaulXiCao
    PaulXiCao committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    08c57fb View commit details
    Browse the repository at this point in the history

  4. handle case: sizeof(double) == sizeof(long double)

    @PaulXiCao
    PaulXiCao committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    5d7bc79 View commit details
    Browse the repository at this point in the history

  5. add hide_from_abi macro to internal functions

    @PaulXiCao
    PaulXiCao committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    5c32b77 View commit details
    Browse the repository at this point in the history

  6. fully qualify local function calls

    @PaulXiCao
    PaulXiCao committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    dfbf54c View commit details
    Browse the repository at this point in the history

  7. remove for operator(): friendlier for older compilers

    @PaulXiCao
    PaulXiCao committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    912833e View commit details
    Browse the repository at this point in the history

  8. document non-naive implementation

    @PaulXiCao
    PaulXiCao committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    458b0d3 View commit details
    Browse the repository at this point in the history

  9. remove unnecessary qualifying of std::array in function return type

    @PaulXiCao
    PaulXiCao committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    9ef79dc View commit details
    Browse the repository at this point in the history

  10. refactor __hypot_factors, e.g. replace std::array usage by std::pair

    @PaulXiCao
    PaulXiCao committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    36a162b View commit details
    Browse the repository at this point in the history

  11. fix std::max not available: undef macros

    @PaulXiCao
    PaulXiCao committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    c276104 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. large literal number throwing error: replace if constexpr by macro gu… 

    …ards
    @PaulXiCao
    PaulXiCao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    cd4ac8a View commit details
    Browse the repository at this point in the history

  2. run clang format

    @PaulXiCao
    PaulXiCao committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    9b06037 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2024

  1. workaround for std::max(std::initializer_list) not found

    @PaulXiCao
    PaulXiCao committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    296c520 View commit details
    Browse the repository at this point in the history

  2. make fp_compare.h ready for pre C++11 tests

    @PaulXiCao
    PaulXiCao committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    a4dd991 View commit details
    Browse the repository at this point in the history

  3. fp_compare: DRY remove duplicate test

    @PaulXiCao
    PaulXiCao committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    7aa6728 View commit details
    Browse the repository at this point in the history

  4. fp_compare: remove unused variable

    @PaulXiCao
    PaulXiCao committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    4294e87 View commit details
    Browse the repository at this point in the history

  5. allow transitive includes: cmath (via __hypot) includes cstddef, cstd… 

    …int, initializer_list
    @PaulXiCao
    PaulXiCao committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    266cef6 View commit details
    Browse the repository at this point in the history

  6. skip test code for pre C++17

    @PaulXiCao
    PaulXiCao committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    69b3b07 View commit details
    Browse the repository at this point in the history

  7. clang format

    @PaulXiCao
    PaulXiCao committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    cb9cecc View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2024

  1. remove single quite digit separator (gcc incompatible?)

    @PaulXiCao
    PaulXiCao committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    d13a2c9 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. fix test for case long double == double

    @PaulXiCao
    PaulXiCao committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    993ef44 View commit details
    Browse the repository at this point in the history