[BOLT] Add NamedRegionTimer to inferStaleProfile

[shawbyoung]

Add a NamedRegionTimer to measure the time spent in inferStaleProfile.

[github-actions]

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[llvmbot]

@llvm/pr-subscribers-bolt

Author: shaw young (shawbyoung)

Changes

Add a NamedRegionTimer to measure the time spent in inferStaleProfile.

---

Full diff: https://github.com/llvm/llvm-project/pull/92621.diff

1 Files Affected:

• (modified) bolt/lib/Profile/StaleProfileMatching.cpp (+5)

diff --git a/bolt/lib/Profile/StaleProfileMatching.cpp b/bolt/lib/Profile/StaleProfileMatching.cpp
index 016962ff34d8d..33182d83449a2 100644
--- a/bolt/lib/Profile/StaleProfileMatching.cpp
+++ b/bolt/lib/Profile/StaleProfileMatching.cpp
@@ -30,6 +30,7 @@
 #include "llvm/ADT/Bitfields.h"
 #include "llvm/ADT/Hashing.h"
 #include "llvm/Support/CommandLine.h"
+#include "llvm/Support/Timer.h"
 #include "llvm/Support/xxhash.h"
 #include "llvm/Transforms/Utils/SampleProfileInference.h"
 
@@ -705,6 +706,10 @@ void assignProfile(BinaryFunction &BF,
 
 bool YAMLProfileReader::inferStaleProfile(
     BinaryFunction &BF, const yaml::bolt::BinaryFunctionProfile &YamlBF) {
+
+  NamedRegionTimer T("inferStaleProfile", "inferring from stale profile",
+                     "rewrite", "Rewrite passes", opts::InferStaleProfile);
+
   if (!BF.hasCFG())
     return false;
 

[aaupov]

Suggested change

	NamedRegionTimer T("inferStaleProfile", "inferring from stale profile",
	NamedRegionTimer T("inferStaleProfile", "stale profile inference",

[aaupov]

Looks good now. Thanks!

[github-actions]

@shawbyoung Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested
by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as
the builds can include changes from many authors. It is not uncommon for your
change to be included in a build that fails due to someone else's changes, or
infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself.
This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

[nico]

This is a dependency cycle: lib/Rewrite depends on lib/Profile, but now Profile also depends on the cl::opt defined in Rewrite.

If you want to do something like this PR, you have to move the definition of this cl::opt to Profile.

[nico]

ProfileTests probably fails to link after this change, and the right fix is not to make it depend on Rewrite, but to fix the layering violation. If it takes a while, consider reverting while you work on the fix.

[aaupov]

This is a dependency cycle: lib/Rewrite depends on lib/Profile, but now Profile also depends on the cl::opt defined in Rewrite.

If you want to do something like this PR, you have to move the definition of this cl::opt to Profile.

Thanks for spotting. Should've tested the shared build as well. Let me revert and we'll reland.