Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Clang][Sema] Avoid pack expansion for expanded empty PackIndexingExprs #92385

Merged
merged 4 commits into from
May 21, 2024

Commits on May 16, 2024

  1. [Clang][Sema] Avoid pack expansion for expanded empty PackIndexingExprs

    We previously doubled the id-expression expansion, even when the pack
    was expanded to empty. The previous condition for determining whether
    we should expand couldn't distinguish between cases where 'the expansion
    was previously postponed' and 'the expansion occurred but resulted in
    emptiness.'
    
    In the latter scenario, we crash because we have not been examining the
    current lambda's parent local instantiation scope since D98068: Any
    Decls instantiated in the parent scope are not visible to the generic
    lambda. And thus any attempt of looking for instantiated Decls in the lambda
    is capped to the current Lambda's LIS.
    
    Fixes llvm#92230
    zyn0217 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    7acbb1d View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Configuration menu
    Copy the full SHA
    afa1de4 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Say 'ExpandedToEmptyPack'

    zyn0217 committed May 20, 2024
    Configuration menu
    Copy the full SHA
    e95fe54 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    56a62cf View commit details
    Browse the repository at this point in the history