Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Clang] Fix Microsoft ABI inheritance model when member pointer is used in a base specifier #91990

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[Clang] Fix Microsoft ABI inheritance model when member pointer is used in a base specifier #91990

wants to merge 7 commits into from

Commits on May 13, 2024

  1. [Clang] Fix Microsoft ABI inheritance model when member pointer is us… 

    …ed in a base specifier

Fix CXXRecordDecl::isParsingBaseSpecifiers so that it is true while parsing base specifiers instead of directly after they have been parsed.

-fcomplete-member-pointers now issues a diagnostic when a member pointer is used in a base specifier.

-fcomplete-member-pointers has also been relaxed to not issue a diagnostic for incomplete classes with an explicit __{single|multiple|virtual}_inheritance attribute, whose completeness would not affect the representation of pointer-to-member objects.
    @MitalAshok
    MitalAshok committed May 13, 2024
    Configuration menu
    Copy the full SHA
    5dc9193 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Merge branch 'main' into ms-member-pointer-in-base

    @MitalAshok
    MitalAshok committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    85a823a View commit details
    Browse the repository at this point in the history

  2. Add more places where -fcomplete-member-pointers should match the Mic… 

    …rosoft ABI
    @MitalAshok
    MitalAshok committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    f343670 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2024

  1. Merge branch 'main' into ms-member-pointer-in-base

    @MitalAshok
    MitalAshok committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    ff6a2b8 View commit details
    Browse the repository at this point in the history

  2. Revert "Add more places where -fcomplete-member-pointers should match… 

    … the Microsoft ABI"

This reverts commit f343670.

I'm planning on moving this to a separate pr which substantially changes -fcomplete-member-pointers
    @MitalAshok
    MitalAshok committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    66c8658 View commit details
    Browse the repository at this point in the history

  3. Partially revert changes to -fcomplete-member-pointers 

    I'm planning on moving this to a separate pr which substantially changes -fcomplete-member-pointers
    @MitalAshok
    MitalAshok committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    7058fb4 View commit details
    Browse the repository at this point in the history

  4. Manipulate the CXXRecordDecl in Sema instead of Parse

    @MitalAshok
    MitalAshok committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    7c619ab View commit details
    Browse the repository at this point in the history