-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flang] Add debug information for module variables. #91582
Merged
Merged
Commits on May 20, 2024
-
[flang] Add initial implementation of module variables.
This PR add supports for module variables and function. The module variables are added as global variables but their scope is set to module instead of compile unit. The scope of function declared inside a module is also set accordingly. After this patch, a module variable could be evaluated in the GDB as `p helper::gli` where helper is name of the module and gli is the name of the variable. A future patch will add the import module functionality which will remove the need to prefix the name with helper::. The line number where is module is declared is a best guess at the moment as this information is not part of the GlobalOp.
Configuration menu - View commit details
-
Copy full SHA for eecff7b - Browse repository at this point
Copy the full SHA eecff7bView commit details -
Following changes were done. 1. Remove MLIR changes as they have been moved to separate PR. 2. Replace std::map with llvm::StringMap 3. Use a direct for loop instead of module.walk.
Configuration menu - View commit details
-
Copy full SHA for e87df98 - Browse repository at this point
Copy the full SHA e87df98View commit details -
Configuration menu - View commit details
-
Copy full SHA for be8a2ba - Browse repository at this point
Copy the full SHA be8a2baView commit details -
1. Skip variables if module list is empty. 2. Add a missing line at the end of a file.
Configuration menu - View commit details
-
Copy full SHA for e90d49a - Browse repository at this point
Copy the full SHA e90d49aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e837cab - Browse repository at this point
Copy the full SHA e837cabView commit details -
Replace 'hasInitializationBody' with 'isInitialized'.
This address one of the review comments.
Configuration menu - View commit details
-
Copy full SHA for 94aecb0 - Browse repository at this point
Copy the full SHA 94aecb0View commit details -
Fixed nits and move IR tests to Integration folder.
Configuration menu - View commit details
-
Copy full SHA for 3487f18 - Browse repository at this point
Copy the full SHA 3487f18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d5c73c - Browse repository at this point
Copy the full SHA 5d5c73cView commit details
Commits on May 21, 2024
-
Add test files that work on fir and test individual passes. Remove the fortran testcase.
Configuration menu - View commit details
-
Copy full SHA for c509126 - Browse repository at this point
Copy the full SHA c509126View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.