Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libc++] basic_ios<wchar_t> cannot store fill character WCHAR_MAX #89305

Merged
merged 24 commits into from
Jul 17, 2024
Merged

[libc++] basic_ios<wchar_t> cannot store fill character WCHAR_MAX #89305

merged 24 commits into from
Jul 17, 2024

Commits on Jun 4, 2024

  1. Use lower max threads to reduce the testing time on AIX.

    @xingxue-ibm
    xingxue-ibm committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    7bd12fb View commit details
    Browse the repository at this point in the history

  2. Changes for cases where wint_t and wchar_t have the same width. The c… 

    …hanges are compatible with the current IBM provided libc++.
    @xingxue-ibm
    xingxue-ibm committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    ecbcaa8 View commit details
    Browse the repository at this point in the history

  3. Addressed comments. 

    - update a comment
    @xingxue-ibm
    xingxue-ibm committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    a54d54a View commit details
    Browse the repository at this point in the history

  4. Addressed comments. 

    -define and use macros _LIBCXX_IOS_MAY_USE_OPTIONAL_FILL and _LIBCXX_IOS_FORCE_OPTIONAL_FILL.
    @xingxue-ibm
    xingxue-ibm committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    8fa650a View commit details
    Browse the repository at this point in the history

  5. Add _LIBCPP_HIDE_FROM_ABI.

    @xingxue-ibm
    xingxue-ibm committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    c033ea9 View commit details
    Browse the repository at this point in the history

  6. Removed changes in unrelated test case.

    @xingxue-ibm
    xingxue-ibm committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    5288cb3 View commit details
    Browse the repository at this point in the history

  7. Add description of ABI change in ReleaseNote.

    @xingxue-ibm
    xingxue-ibm committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    00f4cd2 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Address comment. 

    - expect the test case to pass except windows in abi version 1.
    @xingxue-ibm
    xingxue-ibm committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    e71aafc View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Use helper class _FillHelper by default in ABI version 2.

    @xingxue-ibm
    xingxue-ibm committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    b2ba84c View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary include of __type_traits/conditional.h.

    @xingxue-ibm
    xingxue-ibm committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    33e58ed View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Addressed comments. 

    - add note that the change only affect ABI version 2
- remove "undefining _LIBCXX_IOS_USE_FILL_HELPER to keep the ABI verson 1 behavior"
- add init() functions for class _FillHelper and _SentinelValueFill
    @xingxue-ibm
    xingxue-ibm committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    933f888 View commit details
    Browse the repository at this point in the history

  2. Rename init() to __init().

    @xingxue-ibm
    xingxue-ibm committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    7ef7b82 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Addressed comments. 

    - Use traits_type instead of _Traits to be consistent.
    @xingxue-ibm
    xingxue-ibm committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    9c493f3 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Update libcxx/include/__configuration/abi.h 

    Co-authored-by: Louis Dionne <[email protected]>
    @xingxue-ibm @ldionne
    xingxue-ibm and ldionne authored Jul 4, 2024
    Configuration menu
    Copy the full SHA
    a9280c0 View commit details
    Browse the repository at this point in the history

  2. Update libcxx/include/__configuration/abi.h 

    Co-authored-by: Louis Dionne <[email protected]>
    @xingxue-ibm @ldionne
    xingxue-ibm and ldionne authored Jul 4, 2024
    Configuration menu
    Copy the full SHA
    68edd80 View commit details
    Browse the repository at this point in the history

  3. Update libcxx/include/__configuration/abi.h 

    Co-authored-by: Louis Dionne <[email protected]>
    @xingxue-ibm @ldionne
    xingxue-ibm and ldionne authored Jul 4, 2024
    Configuration menu
    Copy the full SHA
    c0f97c3 View commit details
    Browse the repository at this point in the history

  4. Update libcxx/include/ios 

    Co-authored-by: Louis Dionne <[email protected]>
    @xingxue-ibm @ldionne
    xingxue-ibm and ldionne authored Jul 4, 2024
    Configuration menu
    Copy the full SHA
    49f202f View commit details
    Browse the repository at this point in the history

  5. Addressed comments. 

    - set cmake variable LIBCXX_ABI_DEFINES with the ABI macro for AIX and zOS 64-bit
- remove the note for this change from the release note.
- rename function name __fill() to __get()
- remove REQUIRES from the test case.
    @xingxue-ibm
    xingxue-ibm committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    29a4635 View commit details
    Browse the repository at this point in the history

  6. Remove the unused macro definition for AIX/zOS in abi.h.

    @xingxue-ibm
    xingxue-ibm committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    88fc9eb View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into ios-fill

    @xingxue-ibm
    xingxue-ibm authored Jul 4, 2024
    Configuration menu
    Copy the full SHA
    446f895 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. setfill() WCHAR_MAX instead of WEOF for the test.

    @xingxue-ibm
    xingxue-ibm committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    9ea946e View commit details
    Browse the repository at this point in the history

  2. Fixed format.

    @xingxue-ibm
    xingxue-ibm committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    bf8e923 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. XFAIL targets where WEOF is the same as WCHAR_MAX in libcpp ABI versi… 

    …on 1.
    @xingxue-ibm
    xingxue-ibm committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    ab1cbf7 View commit details
    Browse the repository at this point in the history

  2. Update libcxx/test/std/input.output/iostream.format/std.manip/setfill… 

    …_wchar_max.pass.cpp

Co-authored-by: David Tenty <[email protected]>
    @xingxue-ibm @daltenty
    xingxue-ibm and daltenty authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    5338b67 View commit details
    Browse the repository at this point in the history