Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc++][strings] P2591R5: Concatenation of strings and string views #88389

Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
2d606f4
[libc++][strings] P2591R5: Concatenation of strings and string views
H-G-Hristov Apr 11, 2024
af56ab9
Implemented tests
H-G-Hristov Apr 11, 2024
474d5b9
Cleanup
H-G-Hristov Apr 11, 2024
38f6e85
Restored formatting
H-G-Hristov Apr 11, 2024
ea270b6
Addressed review comments
H-G-Hristov Apr 13, 2024
292cd8f
Removed `constexpr_char_traits` tests
H-G-Hristov Apr 13, 2024
f312052
Merge branch 'main' into hgh/libcxx/P2591R5-Concatenation-of-string-a…
H-G-Hristov Apr 13, 2024
9a86ea1
Use Will Hawkins implementation
H-G-Hristov Apr 15, 2024
695b4b6
Cleanup
H-G-Hristov Apr 15, 2024
2df55a5
Merge branch 'main' into hgh/libcxx/P2591R5-Concatenation-of-string-a…
H-G-Hristov Apr 15, 2024
6b77e5a
Reordered forward declared functions
H-G-Hristov Apr 16, 2024
92d08d6
Merge branch 'main' into hgh/libcxx/P2591R5-Concatenation-of-string-a…
H-G-Hristov May 9, 2024
694e6fd
Fixed rvalue argument overload
H-G-Hristov May 9, 2024
be56164
Workaround for `constexpr_char_traits` not compatible with literals
H-G-Hristov May 10, 2024
20b9120
Minor cleanup
H-G-Hristov May 10, 2024
a8c28fb
Fixed formatting
H-G-Hristov May 10, 2024
16fcbba
Merge branch 'main' into hgh/libcxx/P2591R5-Concatenation-of-string-a…
H-G-Hristov May 10, 2024
bdbaf38
Cleanup
H-G-Hristov May 10, 2024
5d804f5
Merge branch 'main' into hgh/libcxx/P2591R5-Concatenation-of-string-a…
H-G-Hristov May 10, 2024
6e4d6b4
Merge branch 'hgh/libcxx/P2591R5-Concatenation-of-string-and-string-v…
H-G-Hristov May 10, 2024
9f27ece
Try to fix ASAN tests
H-G-Hristov May 10, 2024
43c78be
Merge branch 'main' into hgh/libcxx/P2591R5-Concatenation-of-string-a…
Zingam May 10, 2024
d56da5f
Add a workaround note
H-G-Hristov May 16, 2024
f4f26df
Merge branch 'main' into hgh/libcxx/P2591R5-Concatenation-of-string-a…
H-G-Hristov Jul 10, 2024
da99993
Fixed formatting
H-G-Hristov Jul 10, 2024
907bcc4
Merge branch 'main' into hgh/libcxx/P2591R5-Concatenation-of-string-a…
Zingam Jul 10, 2024
a7bf9a0
WIP - tests with convertible to `string_view`
H-G-Hristov Jul 14, 2024
13d58fe
Merge branch 'main' into hgh/libcxx/P2591R5-Concatenation-of-string-a…
H-G-Hristov Jul 14, 2024
d214ef1
Added ConvertibleToStringView test
H-G-Hristov Jul 14, 2024
20f39e1
Cleanup
H-G-Hristov Jul 14, 2024
666cb62
Merge branch 'main' into hgh/libcxx/P2591R5-Concatenation-of-string-a…
H-G-Hristov Jul 14, 2024
e5e808f
Fixes
H-G-Hristov Jul 14, 2024
d799472
Addressed comments
H-G-Hristov Jul 16, 2024
0820ad9
Merge branch 'main' into hgh/libcxx/P2591R5-Concatenation-of-string-a…
H-G-Hristov Jul 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,9 @@ constexpr void test(const CharT* x, const CharT* y, const CharT* expected) {
}
// string_view + string&&
{
// Create a `basic_string` to workaround clang bug:
// https://github.com/llvm/llvm-project/issues/92382
// Comparison between pointers to a string literal and some other object results in constant evaluation failure.
std::basic_string<CharT, TraitsT, AllocT> st_{x, allocator};
std::basic_string_view<CharT, TraitsT> sv{st_};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record this is a workaround for: #92382

std::basic_string<CharT, TraitsT, AllocT> st{y, allocator};
Expand Down
Loading