-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libc++][strings] P2591R5: Concatenation of strings and string views #88389
Merged
Zingam
merged 34 commits into
llvm:main
from
H-G-Hristov:hgh/libcxx/P2591R5-Concatenation-of-string-and-string-views
Jul 18, 2024
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
2d606f4
[libc++][strings] P2591R5: Concatenation of strings and string views
H-G-Hristov af56ab9
Implemented tests
H-G-Hristov 474d5b9
Cleanup
H-G-Hristov 38f6e85
Restored formatting
H-G-Hristov ea270b6
Addressed review comments
H-G-Hristov 292cd8f
Removed `constexpr_char_traits` tests
H-G-Hristov f312052
Merge branch 'main' into hgh/libcxx/P2591R5-Concatenation-of-string-a…
H-G-Hristov 9a86ea1
Use Will Hawkins implementation
H-G-Hristov 695b4b6
Cleanup
H-G-Hristov 2df55a5
Merge branch 'main' into hgh/libcxx/P2591R5-Concatenation-of-string-a…
H-G-Hristov 6b77e5a
Reordered forward declared functions
H-G-Hristov 92d08d6
Merge branch 'main' into hgh/libcxx/P2591R5-Concatenation-of-string-a…
H-G-Hristov 694e6fd
Fixed rvalue argument overload
H-G-Hristov be56164
Workaround for `constexpr_char_traits` not compatible with literals
H-G-Hristov 20b9120
Minor cleanup
H-G-Hristov a8c28fb
Fixed formatting
H-G-Hristov 16fcbba
Merge branch 'main' into hgh/libcxx/P2591R5-Concatenation-of-string-a…
H-G-Hristov bdbaf38
Cleanup
H-G-Hristov 5d804f5
Merge branch 'main' into hgh/libcxx/P2591R5-Concatenation-of-string-a…
H-G-Hristov 6e4d6b4
Merge branch 'hgh/libcxx/P2591R5-Concatenation-of-string-and-string-v…
H-G-Hristov 9f27ece
Try to fix ASAN tests
H-G-Hristov 43c78be
Merge branch 'main' into hgh/libcxx/P2591R5-Concatenation-of-string-a…
Zingam d56da5f
Add a workaround note
H-G-Hristov f4f26df
Merge branch 'main' into hgh/libcxx/P2591R5-Concatenation-of-string-a…
H-G-Hristov da99993
Fixed formatting
H-G-Hristov 907bcc4
Merge branch 'main' into hgh/libcxx/P2591R5-Concatenation-of-string-a…
Zingam a7bf9a0
WIP - tests with convertible to `string_view`
H-G-Hristov 13d58fe
Merge branch 'main' into hgh/libcxx/P2591R5-Concatenation-of-string-a…
H-G-Hristov d214ef1
Added ConvertibleToStringView test
H-G-Hristov 20f39e1
Cleanup
H-G-Hristov 666cb62
Merge branch 'main' into hgh/libcxx/P2591R5-Concatenation-of-string-a…
H-G-Hristov e5e808f
Fixes
H-G-Hristov d799472
Addressed comments
H-G-Hristov 0820ad9
Merge branch 'main' into hgh/libcxx/P2591R5-Concatenation-of-string-a…
H-G-Hristov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record this is a workaround for: #92382