[libc] Add some integration features into newhdrgen #114272
Draft
+64
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds some command-line switches to the newhdrgen script that facilitate more generalized build system integration. These enable the use of the script in Fuchsia's GN build. The --write-if-changed switch avoids touching the .h output file if it's unchanged, which is beneficial to incremental rebuilds. The --depfile switch writes out a make/ninja-compatible depfile describing the inputs and outputs. This is crucial for build system integration when using the following new feature. When the new --libc-dir switch is given, the YAML file argument is optional. Instead, the --h_def_file input file path must have the --libc-dir path as a prefix and the yaml file is found in its corresponding place in the libc source tree.
|
✅ With the latest revision this PR passed the Python code formatter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some command-line switches to the newhdrgen script
that facilitate more generalized build system integration.
These enable the use of the script in Fuchsia's GN build.
The --write-if-changed switch avoids touching the .h output file
if it's unchanged, which is beneficial to incremental rebuilds.
The --depfile switch writes out a make/ninja-compatible depfile
describing the inputs and outputs. This is crucial for build
system integration when using the following new feature.
When the new --libc-dir switch is given, the YAML file argument
is optional. Instead, the --h_def_file input file path must have
the --libc-dir path as a prefix and the yaml file is found in its
corresponding place in the libc source tree.