Extend kernel-info to emit PGO-based FLOP count #110586
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update NVPTXTargetTransformInfo.cpp's getMaxClusterRank call for interface changes made by 489acb2.
Return the launch bounds instead of passing them to a callback.
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
- Point out floating point types. - Point out when profile data is unavailable. - Otherwise, make remarks less verbose.
They were originally copied from FunctionPropertiesAnalysis.cpp.
See llvm/test/Analysis/KernelInfo/openmp/README.md.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment to combine the capabilities of PGO GPU support (PR #94268) and the kernel-info pass (PR #102944). In particular, it implements an estimation of the number of floating point operations a GPU code executes (profile counts x static floating point op counts). Example usage can be found in
llvm/docs/KernelInfo.rst.The floating point operation count implementation starts at commit d2847b0. A few questions about the implementation appear there as todos. Subsequent commits bring in updates and improvements. Prior commits merge the aforementioned pull requests (not yet landed).