Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SandboxIR] Implement BlockAddress #107940

Merged
merged 1 commit into from
Sep 10, 2024
Merged

[SandboxIR] Implement BlockAddress #107940

merged 1 commit into from
Sep 10, 2024

Conversation

vporpo
Copy link
Contributor

@vporpo vporpo commented Sep 9, 2024

This patch implements sandboxir::BlockAddress mirroring llvm:BlockAddress.

This patch implements sandboxir::BlockAddress mirroring llvm:BlockAddress.
Copy link
Member

@tmsri tmsri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

auto *LookupBB1Addr = sandboxir::BlockAddress::lookup(BB1);
EXPECT_EQ(LookupBB1Addr, BB1Addr);
auto *LookupBB2Addr = sandboxir::BlockAddress::lookup(BB2);
EXPECT_EQ(LookupBB2Addr, nullptr);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@vporpo vporpo merged commit d14a600 into llvm:main Sep 10, 2024
9 checks passed
VitaNuo pushed a commit to VitaNuo/llvm-project that referenced this pull request Sep 12, 2024
This patch implements sandboxir::BlockAddress mirroring
llvm:BlockAddress.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants