Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SandboxIR] Implement FixedVectorType #107930

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

Sterling-Augustine
Copy link
Contributor

No description provided.

Copy link
Contributor

@vporpo vporpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks!

EXPECT_EQ(IVecTy->getElementCount(), FVecTy->getElementCount());
// getExtendedElementCountVectorType
auto *ExtVecTy =
sandboxir::FixedVectorType::getExtendedElementVectorType(IVecTy);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would use a single "input" type across all of these tests that return a type based on the input, like getExtendedElementType(), getTruncatedElementVectorType() and the rest. It makes it easier to know what to expect and easier to read the checks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Sterling-Augustine Sterling-Augustine merged commit bb72865 into llvm:main Sep 10, 2024
5 of 7 checks passed
VitaNuo pushed a commit to VitaNuo/llvm-project that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants