Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc++][type_traits][modules] Added missing std::is_virtual_base_of to type_traits.inc #107009

Merged

Conversation

H-G-Hristov
Copy link
Contributor

std::is_virtual_base_of was implemented in #105847

…e_traits.inc`

`std::is_virtual_base_of` was implemented in llvm#105847
@Zingam Zingam changed the title [libc++][type_traits] Added missing std::is_virtual_base_of to type_traits.inc [libc++][type_traits][modules] Added missing std::is_virtual_base_of to type_traits.inc Sep 2, 2024
@Zingam Zingam marked this pull request as ready for review September 2, 2024 22:48
@Zingam Zingam requested a review from a team as a code owner September 2, 2024 22:48
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Sep 2, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Sep 2, 2024

@llvm/pr-subscribers-libcxx

Author: Hristo Hristov (H-G-Hristov)

Changes

std::is_virtual_base_of was implemented in #105847


Full diff: https://github.com/llvm/llvm-project/pull/107009.diff

1 Files Affected:

  • (modified) libcxx/modules/std/type_traits.inc (+6)
diff --git a/libcxx/modules/std/type_traits.inc b/libcxx/modules/std/type_traits.inc
index d368daf35ccb8c..485a5ddf63aed0 100644
--- a/libcxx/modules/std/type_traits.inc
+++ b/libcxx/modules/std/type_traits.inc
@@ -114,6 +114,9 @@ export namespace std {
 
   // [meta.rel], type relations
   using std::is_base_of;
+#if _LIBCPP_STD_VER >= 26 && __has_builtin(__builtin_is_virtual_base_of)
+  using std::is_virtual_base_of;
+#endif
   using std::is_convertible;
   // using std::is_layout_compatible;
   using std::is_nothrow_convertible;
@@ -287,6 +290,9 @@ export namespace std {
 
   // [meta.rel], type relations
   using std::is_base_of_v;
+#if _LIBCPP_STD_VER >= 26 && __has_builtin(__builtin_is_virtual_base_of)
+  using std::is_virtual_base_of_v;
+#endif
   using std::is_convertible_v;
   using std::is_invocable_r_v;
   using std::is_invocable_v;

Copy link
Member

@ldionne ldionne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing!

@ldionne ldionne merged commit 4640736 into llvm:main Sep 3, 2024
65 checks passed
@H-G-Hristov H-G-Hristov deleted the hgh/libcxx/cxx-modules-virtual_base_of branch September 3, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants