Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc++] Remove unused pair.h include from hypot.h #106798

Merged

Conversation

ldionne
Copy link
Member

@ldionne ldionne commented Aug 30, 2024

This was added in #100820 by mistake since the final version of that PR didn't depend on std::pair anymore.

@ldionne ldionne requested a review from a team as a code owner August 30, 2024 21:04
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Aug 30, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Aug 30, 2024

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

Changes

This was added in #100820 by mistake since the final version of that PR didn't depend on std::pair anymore.


Full diff: https://github.com/llvm/llvm-project/pull/106798.diff

1 Files Affected:

  • (modified) libcxx/include/__math/hypot.h (-1)
diff --git a/libcxx/include/__math/hypot.h b/libcxx/include/__math/hypot.h
index b992163711010a..2c2c9c38ab5302 100644
--- a/libcxx/include/__math/hypot.h
+++ b/libcxx/include/__math/hypot.h
@@ -18,7 +18,6 @@
 #include <__type_traits/is_arithmetic.h>
 #include <__type_traits/is_same.h>
 #include <__type_traits/promote.h>
-#include <__utility/pair.h>
 #include <limits>
 
 #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)

This was added in llvm#100820 by mistake since the final version of
that PR didn't depend on std::pair anymore.
@ldionne ldionne force-pushed the review/modularization-remove-unused-pair-include branch from 428e67c to ad7bba6 Compare September 3, 2024 17:22
@ldionne ldionne merged commit d9019d4 into llvm:main Sep 4, 2024
60 checks passed
@ldionne ldionne deleted the review/modularization-remove-unused-pair-include branch September 4, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants