[libc++][modules] Include __type_traits/invoke.h from __type_traits/result_of.h #106796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldionne
changed the title
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Louis Dionne (ldionne) ChangesThe result_of trait requires the __invoke_of implementation detail, but that is defined under __type_traits, not under __functional. Include the right header directly to remove a dependency from __type_traits to __functional. Full diff: https://github.com/llvm/llvm-project/pull/106796.diff 1 Files Affected:
diff --git a/libcxx/include/__type_traits/result_of.h b/libcxx/include/__type_traits/result_of.h
index f00fa8e9be7f73..73a19447520663 100644
--- a/libcxx/include/__type_traits/result_of.h
+++ b/libcxx/include/__type_traits/result_of.h
@@ -10,7 +10,7 @@
#define _LIBCPP___TYPE_TRAITS_RESULT_OF_H
#include <__config>
-#include <__functional/invoke.h>
+#include <__type_traits/invoke.h>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header
|
philnik777
approved these changes
Aug 30, 2024
The result_of trait requires the __invoke_of implementation detail, but that is defined under __type_traits, not under __functional. Include the right header directly to remove a dependency from __type_traits to __functional.
ldionne
force-pushed
the
review/modularization-result-of-invoke
branch
from
b83a660
to
46561c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result_of trait requires the __invoke_of implementation detail, but that is defined under __type_traits, not under __functional. Include the right header directly to remove a dependency from __type_traits to __functional.