Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLIR][AMDGPU] Add OCP FP8 support for new hardware #106160

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Commits on Sep 16, 2024

  1. [MLIR][AMDGPU] Add OCP FP8 support to for new hardware

    Upcoming hardware (gfx12 and some future gfx9) will support the OCP
    8-bit float formats for their matrix multiplication intrinsics and
    conversion operations, retaining existing opcodes and compiler builtins.
    
    This commit adds support for these types to the MLIR wrappers around
    such operations, ensuring that the OCP types aren't used to generate
    those builtins on hardware that doesn't expect that format and,
    conversely, to ensure that the pre-OCP formats aren't used on new
    hardware.
    pcf000 committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    0272474 View commit details
    Browse the repository at this point in the history
  2. [MLIR][AMDGPU] After fp8 conversions were lowered to AMDGPU dialect ops,

    those operations were not being converted to the LLVM intrinsics they
    correspond to because the rewrite patterns were still checking for
    gfx940+.
    
    As part of this, factor out tests for type-match isto isNativeFp8()
    and isNativeBf8() functions in the AMDGPUToRocdl rewrites.
    
    Also, fix a typo in isGfx940() that caused it to be true for gfx950.
    
    Finally, test all these OCP format conversions by duplicating the
    gfx940 tests.
    krzysz00 authored and pcf000 committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    1848df4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1b790e3 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Configuration menu
    Copy the full SHA
    de5a263 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Configuration menu
    Copy the full SHA
    a62c37c View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Use isa<>.

    pcf000 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    fd0f519 View commit details
    Browse the repository at this point in the history