[DirectX] Add triples to two tests after #97593 #101779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of cdfd884 "[DXIL] Add DXIL version-specific TableGen specification and implementation of DXIL Ops (llvm#97593)", all of these tests need to specify triples.
|
@llvm/pr-subscribers-backend-directx Author: Justin Bogner (bogner) ChangesAs of cdfd884 "[DXIL] Add DXIL version-specific TableGen specification and implementation of DXIL Ops (#97593)", all of these tests need to specify triples. Full diff: https://github.com/llvm/llvm-project/pull/101779.diff 2 Files Affected:
diff --git a/llvm/test/CodeGen/DirectX/any.ll b/llvm/test/CodeGen/DirectX/any.ll
index e8d87075d65cf..ceb8077af311d 100644
--- a/llvm/test/CodeGen/DirectX/any.ll
+++ b/llvm/test/CodeGen/DirectX/any.ll
@@ -1,4 +1,4 @@
-; RUN: opt -S -dxil-op-lower < %s | FileCheck %s
+; RUN: opt -S -dxil-op-lower -mtriple=dxil-pc-shadermodel6.0-library < %s | FileCheck %s
; Make sure dxil operation function calls for any are generated for float and half.
diff --git a/llvm/test/CodeGen/DirectX/lerp.ll b/llvm/test/CodeGen/DirectX/lerp.ll
index ebd7e133b5163..9f5e4c7710d21 100644
--- a/llvm/test/CodeGen/DirectX/lerp.ll
+++ b/llvm/test/CodeGen/DirectX/lerp.ll
@@ -1,4 +1,4 @@
-; RUN: opt -S -dxil-op-lower < %s | FileCheck %s
+; RUN: opt -S -dxil-op-lower -mtriple=dxil-pc-shadermodel6.0-library < %s | FileCheck %s
; Make sure dxil operation function calls for lerp are generated for float and half.
|
llvm-beanz
approved these changes
Aug 3, 2024
bharadwajy
approved these changes
Aug 3, 2024
banach-space
pushed a commit
to banach-space/llvm-project
that referenced
this pull request
Aug 7, 2024
As of cdfd884 "[DXIL] Add DXIL version-specific TableGen specification and implementation of DXIL Ops (llvm#97593)", all of these tests need to specify triples.
kstoimenov
pushed a commit
to kstoimenov/llvm-project
that referenced
this pull request
Aug 15, 2024
As of cdfd884 "[DXIL] Add DXIL version-specific TableGen specification and implementation of DXIL Ops (llvm#97593)", all of these tests need to specify triples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of cdfd884 "[DXIL] Add DXIL version-specific TableGen specification and implementation of DXIL Ops (#97593)", all of these tests need to specify triples.