-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sanitizer] Document AddressSanitizer security considerations #100937
Conversation
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write If you have received no comments on your PR for a week, you can request a review If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
@llvm/pr-subscribers-clang Author: None (bigb4ng) ChangesFollow-up to #92593. Also makes #92611, google/sanitizers#1130 obsolete. Full diff: https://github.com/llvm/llvm-project/pull/100937.diff 1 Files Affected:
diff --git a/clang/docs/AddressSanitizer.rst b/clang/docs/AddressSanitizer.rst
index e1997153f2037..d543b49d64c05 100644
--- a/clang/docs/AddressSanitizer.rst
+++ b/clang/docs/AddressSanitizer.rst
@@ -313,6 +313,14 @@ Limitations
usually expected.
* Static linking of executables is not supported.
+Security Considerations
+=======================
+
+AddressSanitizer is a bug detection tool and is not meant to be linked
+against production executables. While it may be useful for testing,
+AddressSanitizer's runtime was not developed with security-sensitive
+constraints in mind and may compromise the security of the resulting executable.
+
Supported Platforms
===================
|
|
@bigb4ng please do this. Thank you |
This applies as well to MemorySanitizer, ThreadSanitizer, LeakSanitizer, HWAddressSanitizer, more or less UBSan with diagnostics. Would you like to update those as well? |
e37995b
to
7f45c42
Compare
@vitalybuka Done. @fmayer If you have any other nits (especially for GWP-ASan section) I'd be glad to hear them. |
Don't forget to click "re-request review" after updating PRs, or it's not displayed as pending review request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % vitaly's comment
Follow-up to PR llvm#92593
7f45c42
to
6e2b5ab
Compare
@vitalybuka Unfortunately I cannot re-request since previous review is still pending. Anyway I've included trap mode too. |
@bigb4ng Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
Follow-up to #92593.
Also makes #92611, google/sanitizers#1130 obsolete.