Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clang] Handle tm mangling on Solaris in PPMacroExpansion.cpp #100724

Merged
merged 1 commit into from
Jul 26, 2024
Merged

[clang] Handle tm mangling on Solaris in PPMacroExpansion.cpp #100724

merged 1 commit into from
Jul 26, 2024

Commits on Jul 26, 2024

  1. [clang] Handle tm mangling on Solaris in PPMacroExpansion.cpp 

    The introduction of `std::put_time` in
fad17b4 broke the Solaris build:
```
Undefined			first referenced
 symbol  			    in file
_ZNKSt8time_putIcSt19ostreambuf_iteratorIcSt11char_traitsIcEEE3putES3_RSt8ios_basecPKSt2tmPKcSB_ lib/libclangLex.a(PPMacroExpansion.cpp.o)
ld: fatal: symbol referencing errors
```
As discussed in PR llvm#99075, the problem is that GCC mangles `std::tm` as
`tm` on Solaris for binary compatility, while `clang` doesn't (Issue

As a stop-gap measure, this patch introduces an `asm` level alias to the
same effect.

Tested on `sparcv9-sun-solaris2.11`, `amd64-pc-solaris2.11`, and
`x86_64-pc-linux-gnu`.
    @rorth
    rorth committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    139569a View commit details
    Browse the repository at this point in the history