Add a comment why I check for corefiles & clarify msg

llvm · Jul 16, 2024 · e3c60ee · e3c60ee
1 parent 2e89de9
commit e3c60ee
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lldb/source/Core/DynamicLoader.cpp b/lldb/source/Core/DynamicLoader.cpp
@@ -223,7 +223,7 @@ ModuleSP DynamicLoader::LoadBinaryWithUUIDAndAddress(
   FileSpec name_filespec(name);
 
   if (uuid.IsValid()) {
-    Progress progress("Locating external symbol file",
+    Progress progress("Locating binary",
                       prog_str.GetString().str());
 
     // Has lldb already seen a module with this UUID?

diff --git a/lldb/source/Target/Process.cpp b/lldb/source/Target/Process.cpp
@@ -2547,6 +2547,8 @@ ModuleSP Process::ReadModuleFromMemory(const FileSpec &file_spec,
   if (module_sp) {
     Status error;
     std::unique_ptr<Progress> progress_up;
+    // Reading an ObjectFile from a local corefile is very fast,
+    // don't print a progress report.  
     if (!GetCoreFile())
       progress_up = std::make_unique<Progress>(
           "Reading binary from memory", file_spec.GetFilename().GetString());