Skip to content

Commit

Permalink
Clarify my corefile check in ReadModuleFromMemory
Browse files Browse the repository at this point in the history
Greg's suggestion is better.
  • Loading branch information
jasonmolenda committed Jul 17, 2024
1 parent ebd9b8b commit dbbda57
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions lldb/source/Target/Process.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2548,8 +2548,9 @@ ModuleSP Process::ReadModuleFromMemory(const FileSpec &file_spec,
Status error;
std::unique_ptr<Progress> progress_up;
// Reading an ObjectFile from a local corefile is very fast,
// don't print a progress report.
if (!GetCoreFile())
// only print a progress update if we're reading from a
// live session which might go over gdb remote serial protocol.
if (IsLiveDebugSession())
progress_up = std::make_unique<Progress>(
"Reading binary from memory", file_spec.GetFilename().GetString());

Expand Down

0 comments on commit dbbda57

Please sign in to comment.