Skip to content

Commit

Permalink
Extend GCC workaround to GCC < 8.4 for llvm::iterator_range ctor (#82643
Browse files Browse the repository at this point in the history
)

GCC SFINAE error with decltype was fixed in commit
ac5e28911abdfb8d9bf6bea980223e199bbcf28d which made it into GCC 8.4.
Therefore adjust GCC version test accordingly.

(cherry picked from commit 7f71fa9)
  • Loading branch information
RoboTux authored and llvmbot committed Feb 22, 2024
1 parent 6c90f8d commit b9029ed
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions llvm/include/llvm/ADT/iterator_range.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ class iterator_range {
IteratorT begin_iterator, end_iterator;

public:
#if __GNUC__ == 7
// Be careful no to break gcc-7 on the mlir target.
#if __GNUC__ == 7 || (__GNUC__ == 8 && __GNUC_MINOR__ < 4)
// Be careful no to break gcc-7 and gcc-8 < 8.4 on the mlir target.
// See https://github.com/llvm/llvm-project/issues/63843
template <typename Container>
#else
Expand Down

0 comments on commit b9029ed

Please sign in to comment.