Skip to content

Commit

Permalink
[libc++] Fix sized deallocation comments in tests (#98173)
Browse files Browse the repository at this point in the history
Clang 19 turned on sized deallocation *by default*, but older versions
of Clang did support sized deallocation nonetheless. This updates a few
comments and removes UNSUPPORTED annotations that shouldn't be needed in
a test that passes -fsized-deallocation directly.
  • Loading branch information
ldionne authored Jul 10, 2024
1 parent d100631 commit ad01635
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
//
//===----------------------------------------------------------------------===//

// test libc++'s implementation of align_val_t, and the relevant new/delete
// Test libc++'s implementation of align_val_t, and the relevant new/delete
// overloads in all dialects when -faligned-allocation is present.

// Libc++ when built for z/OS doesn't contain the aligned allocation functions,
Expand All @@ -21,9 +21,6 @@
// GCC doesn't support the aligned-allocation flags.
// XFAIL: gcc

// These compiler versions do not have proper sized deallocation support.
// UNSUPPORTED: clang-17, clang-18

// RUN: %{build} -faligned-allocation -fsized-deallocation
// RUN: %{run}
// RUN: %{build} -faligned-allocation -fno-sized-deallocation -DNO_SIZE
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

// test sized operator delete[] replacement.

// These compiler versions do not have proper sized deallocation support.
// These compiler versions don't enable sized deallocation by default.
// UNSUPPORTED: clang-17, clang-18

// UNSUPPORTED: sanitizer-new-delete, c++03, c++11
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
//
//===----------------------------------------------------------------------===//

// test sized operator delete replacement.
// Test sized operator delete replacement.

// These compiler versions do not have proper sized deallocation support.
// These compiler versions do not enable sized deallocation by default.
// UNSUPPORTED: clang-17, clang-18

// UNSUPPORTED: sanitizer-new-delete, c++03, c++11
Expand Down

0 comments on commit ad01635

Please sign in to comment.