Use SpecificBumpPtrAllocator to allocate mem and make sure to call de…

…structors
llvm · May 16, 2024 · 9ae0fca · 9ae0fca
1 parent 8e64fa9
commit 9ae0fca
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/llvm/lib/IR/Attributes.cpp b/llvm/lib/IR/Attributes.cpp
@@ -211,10 +211,9 @@ Attribute Attribute::get(LLVMContext &Context, Attribute::AttrKind Kind,
   if (!PA) {
     // If we didn't find any existing attributes of the same shape then create a
     // new one and insert it.
-    void *Mem = pImpl->Alloc.Allocate(
-        ConstantRangeListAttributeImpl::totalSizeToAlloc(Val),
-        alignof(ConstantRangeListAttributeImpl));
-    PA = new (Mem) ConstantRangeListAttributeImpl(Kind, Val);
+    PA = new (pImpl->ConstantRangeListAttributeAlloc.Allocate(
+        ConstantRangeListAttributeImpl::totalSizeToAlloc(Val)))
+        ConstantRangeListAttributeImpl(Kind, Val);
     pImpl->AttrsSet.InsertNode(PA, InsertPoint);
   }
 

diff --git a/llvm/lib/IR/ConstantRangeList.cpp b/llvm/lib/IR/ConstantRangeList.cpp
@@ -38,7 +38,7 @@ void ConstantRangeList::insert(const ConstantRange &NewRange) {
   // Slow insert.
   SmallVector<ConstantRange, 2> ExistingTail(LowerBound, Ranges.end());
   Ranges.erase(LowerBound, Ranges.end());
-  // "sle" instead of "slt" to merge consecutive ranges.
+  // Merge consecutive ranges.
   if (!Ranges.empty() && NewRange.getLower().sle(Ranges.back().getUpper())) {
     APInt NewLower = Ranges.back().getLower();
     APInt NewUpper =

diff --git a/llvm/lib/IR/LLVMContextImpl.h b/llvm/lib/IR/LLVMContextImpl.h
@@ -57,6 +57,7 @@ class AttributeListImpl;
 class AttributeSetNode;
 class BasicBlock;
 class ConstantRangeAttributeImpl;
+class ConstantRangeListAttributeImpl;
 struct DiagnosticHandler;
 class DbgMarker;
 class ElementCount;
@@ -1581,6 +1582,8 @@ class LLVMContextImpl {
   UniqueStringSaver Saver{Alloc};
   SpecificBumpPtrAllocator<ConstantRangeAttributeImpl>
       ConstantRangeAttributeAlloc;
+  SpecificBumpPtrAllocator<ConstantRangeListAttributeImpl>
+      ConstantRangeListAttributeAlloc;
 
   DenseMap<unsigned, IntegerType *> IntegerTypes;