Skip to content

Commit

Permalink
Remove explicit installation step from run-buildbot since we now alwa…
Browse files Browse the repository at this point in the history
…ys do it before we run the test suite
  • Loading branch information
ldionne committed Jul 2, 2024
1 parent b7b115d commit 83b3d10
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions libcxx/utils/ci/run-buildbot
Original file line number Diff line number Diff line change
Expand Up @@ -154,19 +154,6 @@ function check-runtimes() {

echo "+++ Running the libunwind tests"
${NINJA} -vC "${BUILD_DIR}" check-unwind

# TODO: On macOS 13.5, the linker seems to have an issue where it will pick up
# a library if it exists inside a -L search path, even if we don't link
# against that library. This happens with libunwind.dylib if it is built
# at the point when we run the libc++ tests, which causes issues cause we
# are also linking against the system unwinder.
#
# I believe this is a linker regression and I reported it as rdar://115842730.
# It should be possible to move this installation step back to the top once
# that issue has been resolved, but in the meantime it doesn't really hurt to
# have it here.
echo "--- Installing libc++, libc++abi and libunwind to a fake location"
${NINJA} -vC "${BUILD_DIR}" install-cxx install-cxxabi install-unwind
}

# TODO: The goal is to test this against all configurations. We should also move
Expand Down

0 comments on commit 83b3d10

Please sign in to comment.