Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
teresajohnson committed Jul 11, 2024
1 parent 3ad6a4e commit 75a8eb9
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 5 deletions.
2 changes: 1 addition & 1 deletion llvm/include/llvm/IR/ModuleSummaryIndex.h
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ inline raw_ostream &operator<<(raw_ostream &OS, const AllocInfo &AE) {
if (!AE.TotalSizes.empty()) {
OS << " TotalSizes per MIB:\n\t\t";
First = true;
for (auto &TS : AE.TotalSizes) {
for (uint64_t TS : AE.TotalSizes) {
if (!First)
OS << ", ";
First = false;
Expand Down
2 changes: 0 additions & 2 deletions llvm/test/ThinLTO/X86/memprof-basic.ll
Original file line number Diff line number Diff line change
Expand Up @@ -267,11 +267,9 @@ attributes #0 = { noinline optnone }
; DUMP: Edge from Callee [[BAR2]] to Caller: [[BAZ2]] AllocTypes: Cold ContextIds: 2
; DUMP: Clone of [[BAR]]


; SIZES: NotCold context 1 with total size 100 is NotCold after cloning
; SIZES: Cold context 2 with total size 400 is Cold after cloning


; REMARKS: call in clone main assigned to call function clone _Z3foov.memprof.1
; REMARKS: created clone _Z3barv.memprof.1
; REMARKS: call in clone _Z3barv marked with memprof allocation attribute notcold
Expand Down
2 changes: 0 additions & 2 deletions llvm/test/Transforms/MemProfContextDisambiguation/basic.ll
Original file line number Diff line number Diff line change
Expand Up @@ -249,11 +249,9 @@ attributes #6 = { builtin }
; REMARKS: call in clone _Z3bazv assigned to call function clone _Z3barv
; REMARKS: call in clone _Z3barv marked with memprof allocation attribute notcold


; SIZES: NotCold context 1 with total size 100 is NotCold after cloning
; SIZES: Cold context 2 with total size 400 is Cold after cloning


; IR: define {{.*}} @main
;; The first call to foo does not allocate cold memory. It should call the
;; original functions, which ultimately call the original allocation decorated
Expand Down

0 comments on commit 75a8eb9

Please sign in to comment.