Skip to content

Commit

Permalink
[libc++] Narrow the exports for common_type
Browse files Browse the repository at this point in the history
Based on a comment in #99473, it seems like `export *` may be overkill.
  • Loading branch information
ldionne committed Oct 9, 2024
1 parent 21da4e7 commit 7076b7f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions libcxx/include/module.modulemap
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@ module std_core [system] {
module common_reference { header "__type_traits/common_reference.h" }
module common_type {
header "__type_traits/common_type.h"
// We need to export everything from this module because common_type inherits from __builtin_common_type,
// which needs to be re-exported.
export *
// We need to export those because common_type expands to either of those based on __builtin_common_type.
export std_core.type_traits.type_identity
export std_core.utility_core.empty
}
module conditional { header "__type_traits/conditional.h" }
module conjunction { header "__type_traits/conjunction.h" }
Expand Down

0 comments on commit 7076b7f

Please sign in to comment.