Fix include path for pkg-config #235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajl headers are supposed to be installed straight into $PREFIX/include/yajl and they're supposed to be included as <yajl/yajl_something.h>, according to the documentation. However, pkg-config returns CFLAGS as $PREFIX/include/yajl and that breaks build because "#include <yajl/yajl_something.h>" can't find the header. This is a problem if $PREFIX is different from /usr or other include directory that's used implicitly (which is a case on macOS with homebrew, where every package has its own $PREFIX).
robohack
added a commit
to robohack/yajl
that referenced
this pull request
May 13, 2021
This is from lloyd/yajl#235 Also fix and update some comments, and the package description.
|
I've fixed this on my fork: https://github.com/robohack/yajl (on the default "bsdmake" branch). There are other fixes also included in my branch, as well as a rewrite of the build system and documentation generation (to avoid the CMake disaster), as well as a full replacement for the pgksrc devel/yajl module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yajl headers are supposed to be installed straight into $PREFIX/include/yajl
and they're supposed to be included as <yajl/yajl_something.h>, according to
the documentation.
However, pkg-config returns CFLAGS as $PREFIX/include/yajl and that
breaks build because "#include <yajl/yajl_something.h>" can't find the
header.
This is a problem if $PREFIX is different from /usr or other include
directory that's used implicitly (which is a case on macOS with
homebrew, where every package has its own $PREFIX).