Guard VS configuration in CMake file with MSVC
#228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CMake file is implicitly assuming that Microsoft Visual Studio is the only compiler for Windows, which is of course false. The Microsoft Visual Studio-specific configuration should be guarded with [`MSVC`](https://cmake.org/cmake/help/latest/variable/MSVC.html). This change makes it possible to build YAJL with MinGW for example, see [this patch](https://github.com/msys2/MINGW-packages/blob/11cf0665cfd6a4cf70fea61f60374a5dc07ee5f3/mingw-w64-yajl/01-fix-compiler.patch) in the MINGW-packages repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMake file is implicitly assuming that Microsoft Visual Studio is the only compiler for Windows, which is of course false. The Microsoft Visual Studio-specific configuration should be guarded with
MSVC. This change makes it possible to build YAJL with MinGW for example, see this patch in the MINGW-packages repository.