cmake: Fix installing pkg-config file into libdir #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the CMake rules to install pkg-config file into lib/pkgconfig rather than share/pkgconfig. The former location is correct for ABI-dependent files such as libraries, while the latter should be used only for ABI-agnostic resources (data files, executables). This fixes using yajl on multilib systems where 32-bit and 64-bit versions of the library are installed separately. This requires two separate pkg-config files to be installed along with the libraries into appropriate libdirs. When the file was installed into /usr/share, only one variant was permitted and effectively using the other multilib variant was broken, breaking other packages. Original bug report: https://bugs.gentoo.org/677870
|
This has been submitted as #158 previously but my PR is more complete as it changes internal layout as well. |
|
Ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the CMake rules to install pkg-config file into lib/pkgconfig
rather than share/pkgconfig. The former location is correct
for ABI-dependent files such as libraries, while the latter should be
used only for ABI-agnostic resources (data files, executables).
This fixes using yajl on multilib systems where 32-bit and 64-bit
versions of the library are installed separately. This requires two
separate pkg-config files to be installed along with the libraries
into appropriate libdirs. When the file was installed into /usr/share,
only one variant was permitted and effectively using the other multilib
variant was broken, breaking other packages.
Original bug report: https://bugs.gentoo.org/677870