pkgconfig, static lib and uClibc linking fixes #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 28, 2015 17:40
Signed-off-by: Vicente Olivert Riera <[email protected]>
The will be differentiated by the extension (.so or .a) Signed-off-by: Vicente Olivert Riera <[email protected]>
Signed-off-by: Vicente Olivert Riera <[email protected]>
json_reformat, yajl_test and gen-extra-close call yajl_gen_* functions, which internally use isnan() and isinf(). On glibc, these are provided by libc, but on uClibc you need to link with -lm (like the spec says), otherwise the build process will fail with an error like this one: yajl_gen.c:(.text+0x67c): undefined reference to `__isnan' yajl_gen.c:(.text+0x70c): undefined reference to `__isinf' Signed-off-by: Vicente Olivert Riera <[email protected]>
This was referenced Oct 29, 2015
vincent-olivert-riera
changed the title
tpetazzoni
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Nov 22, 2015
mpd's plugin soundcloud requires yajl. In static build context yajl library is named yajl_s so linking against yajl fails: /bin/ld: cannot find -lyajl Use a pull request patch [1] to let the shared and the static library have the same name. They will be differentiated by the extension (.so or .a). Fixes: http://autobuild.buildroot.net/results/5ac/5acba9b0ed852512fc88e83973a3b5389e6d54be/ http://autobuild.buildroot.net/results/739/73934ad67efa121fedeaa03fdad290aa63f1485e/ [1] lloyd/yajl#174 Signed-off-by: Jörg Krause <[email protected]> Signed-off-by: Thomas Petazzoni <[email protected]>
|
@lloyd is this good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains the following commits:
Install the pkgconfig file in the usual location
Let the shared and the static library have the same name
Allow the user to not build the shared library
Fix json_reformat, yajl_test and gen-extra-close linking with uClibc