Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partial revert to fix compatible issue #1892

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wkpark
Copy link

@wkpark wkpark commented Sep 22, 2024

  • fix submit(), submit_*(), create_submit_args()
  • add console.warn = function(){}; to ignore bunch of warnings extracted to another PR.

these submit*() are used several extensions by means of hook or direct call.
this fix revert some part of gradio 4 fix to make it more compatible with A1111.
for example, uddetailer use submit.apply() call directly.

javascript/gradio.js Outdated Show resolved Hide resolved
@lllyasviel
Copy link
Owner

hi do you have some code links to what might be using this to help understanding

@wkpark
Copy link
Author

wkpark commented Sep 23, 2024

hi do you have some code links to what might be using this to help understanding

https://github.com/wkpark/uddetailer/blob/master/javascript/ui.js#L8-L31

https://github.com/wkpark/uddetailer/blob/master/scripts/ddetailer.py#L2455-L2468

this way, any extensions can use/hook "Generate" image feature. (uddetailer support inpainting feature)

 * add console.warn = function(){}; to ignore bunch of warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants